-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): send graphql closing boundary to fit Apollo client #1579
Merged
alepane21
merged 10 commits into
main
from
dave/eng-6353-multipart-http-subscription-boundary-issue
Feb 18, 2025
Merged
fix(router): send graphql closing boundary to fit Apollo client #1579
alepane21
merged 10 commits into
main
from
dave/eng-6353-multipart-http-subscription-boundary-issue
Feb 18, 2025
+220
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Router image scan passed✅ No security vulnerabilities found in image:
|
I was able to verify locally that this change fixes the error from the apollo client. |
jensneuse
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Users noted that our Multipart implementation, while it works and fits the spec (RFC1341), wasn't being correctly parsed by some clients. Specifically, the client wouldn't parse one message until the next message had been pushed, with it's
--graphql
prefix.This stems from an issue in their implementation, but we want to ensure that our router is accessible by as many services as possible.
The response now has the
--graphql
of the next response being sent early, which doesn't seem to impact any other services that I've checked. If necessary, we can hide this behind a feature flag so it's specific for apollowget
curl
Apollo Client
Checklist